Conversation
Owner
Author
|
Midscene CI 验证:Voxtype 设置页单用例在 Ubuntu 1/1 首次通过、7/7 步骤通过:https://github.com/quanru/doubao-say/actions/runs/35817545852 ;真实 Omarchy VM 1/1 通过(首次尝试最后一条视觉断言未通过,第二次完整通过):https://github.com/quanru/doubao-say/actions/runs/35818162194 。覆盖 CLI/daemon 版本与状态、引擎/模型/设备/后端/schema 展示、隐藏 API Key、刷新按钮和打开配置按钮的 UI 反馈。CI 使用假 CLI;配置按钮的终端启动副作用和真实 Voxtype 环境不属于本次 Midscene 覆盖。最后一次合并只同步 #48 的 runner 路由,合并前后文件树无差异。 |
…into feat/voxtype-controls
…into feat/voxtype-controls
…into feat/voxtype-controls
This was referenced Sep 25, 2026
Midscene visual review: conclusion withdrawn
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configureTUI in an available terminal instead of rewriting its configurationDependency
Depends on #48.
Validation
PYTHONPATH=src /Users/bytedance/personal/doubao-say/.venv/bin/python -m unittest tests.unit.test_voxtype_control tests.unit.test_voxtype_runtime tests.unit.test_voxtype_asr_client tests.unit.test_recognition_providers/Users/bytedance/personal/doubao-say/.venv/bin/python -m ruff check src tests packagingPYTHONPATH=src /Users/bytedance/personal/doubao-say/.venv/bin/python -m compileall -q src testsstatus --extended --format jsonandconfig schema --jsonsource contractsgit diff --checkValidation gaps
voxtype configure; it does not embed a second configuration editorReview order
Review after #48. This is the final PR in the recognition-provider stack.
Review fix (2026-09-25)
GLib.idle_add, keeping GTK responsive while CLI commands run.Validation on Linux:
make PYTHON=/home/leyang/doubao-say/.venv/bin/python checkandmake PYTHON=/home/leyang/doubao-say/.venv/bin/python coveragepassed (61% overall coverage). Voxtype 1.0.1 was subsequently tested with a virtual PipeWire microphone. A GTK screenshot and physical microphone acceptance were not captured.Live Linux benchmark (2026-09-25)
0631ad1);make checkpasses on this branch.TranscriptionManagerruns after capture became ready.Audio startup follow-up (2026-09-25)
c866b8fso the app no longer reports recording as soon as Voxtype merely acknowledges the CLI signal.make checkpasses on this branch.